Improve file hashing #114
Merged
Improve file hashing #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the files in a separate thread and then send the keccak preimage through a channel to the main thread. This improves the performance in ~13% without changing the hash output.
eljobe
reviewed
Nov 2, 2024
This makes the unit tests more resilient to changes in the rust environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the file hashing algorithm by parallelizing the file IO and the hashing accumulation. It also adds a unit test to ensure the changes don't affect the hash output.
Running the benchmark on my machine (Macbook M3) with mocked data, I got the following results:
We could improve more if we changed the algorithm to hash each file independently and then accumulate all the resulting hashes. However, this would change the resulting hash and is probably not worth it.
Close STY-158